Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cta): introduce button variant #4779

Merged
merged 1 commit into from
Dec 28, 2020

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Dec 24, 2020

Related Ticket(s)

Refs #3556.

Description

Introudces button variant of the CTA, that inherits <dds-button-group-item>.

<dds-btn>, the parent class of <dds-button-group-item>, is written from scratch (instead of inheriting <bx-btn>) so it opens up the APIs that CTA requires.

Changelog

New

  • <dds-button-cta>, a button variant of CTA, inheriting <dds-button-group-item>.

Introudces button variant of the CTA, that inherits
`<dds-button-group-item>`.

`<dds-btn>`, the parent class of `<dds-button-group-item>`, is
written from scratch (instead of inheriting `<bx-btn>`) so it opens up
the APIs that CTA requires.

Refs carbon-design-system#3556.
@asudoh asudoh added the package: web components Work necessary for the IBM.com Library web components package label Dec 24, 2020
@ibmdotcom-bot
Copy link
Contributor

@ibmdotcom-bot
Copy link
Contributor

@ibmdotcom-bot
Copy link
Contributor

Copy link
Contributor

@guilhermelMoraes guilhermelMoraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the help, @asudoh! 👍🏻

@guilhermelMoraes guilhermelMoraes merged commit bbe4744 into carbon-design-system:master Dec 28, 2020
@asudoh asudoh deleted the button-cta branch December 29, 2020 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: web components Work necessary for the IBM.com Library web components package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants